Skip to content

Skip two k8s-failing tests - #2002

Open
vgpopov wants to merge 6 commits into
mainfrom
vp/skip-flaky-mnz-dry-run
Open

vgpopov wants to merge 6 commits into
mainfrom
vp/skip-flaky-mnz-dry-run

Conversation

@vgpopov

@vgpopov vgpopov commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Skip two tests that fail the k8s monorepo job of pl CI.

  • exec/mnz.test.ts > should run dry-run monetization and return info with remaining runs. In pl run 43274101547 (job 131385385820), it timed out at 15s on all three tries. The other test of the same file passed only on its retry. The PR that raises the test budget on k8s to 60s is separate. Turn this test on again after that PR lands.
  • v2/effect.test.ts > a failed import fails the effect, on the k8s backend only (PL_TEST_K8S=1). It fails on all three tries with promise resolved "[ 'file', 'progress' ]" instead of rejecting, in pl run 43410351811 (job 131838335756) and in the pl main nightly runs of 2026-11-12 and 2026-11-13. The wait from c6d29a8 is in place, so this is not the read-before-error race. On k8s the data library is in S3. The backend logs show that the S3 index sets the error on the BlobIndex (HeadObject 404, item not found), but the effect map gets ready with no error. The localfs job keeps this test.
  • The dedup test fix of template_cache.test.ts and template-cache-v3.test.ts is gone from this PR: main fixed the same tests in c8bbf03 and ec893f4, which compare the global ids.

🤖 Generated with Claude Code

On the k8s backend of pl CI it times out at 15s on all three tries.
@greptile-apps

greptile-apps Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a4c897c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.99%. Comparing base (a919c7c) to head (a4c897c).
⚠️ Report is 23 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2002   +/-   ##
=======================================
  Coverage   60.99%   60.99%           
=======================================
  Files         444      444           
  Lines       24135    24135           
  Branches     5692     5692           
=======================================
  Hits        14720    14720           
  Misses       7741     7741           
  Partials     1674     1674           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

On the k8s backend the data library is in S3. The effect map gets ready with no import error, so the test fails on all three tries, also in the nightly runs of pl main.
@vgpopov vgpopov changed the title Skip the flaky dry-run monetization test Skip two tests that fail the k8s monorepo job Nov 13, 2026
When the legacy template is saved first, the cached template's originalResourceId carries a signature, while the legacy id from toGlobalResourceId has none. The same resource 219 then gave '219|08db...' and '219|', and the test failed (platforma run 43417487993).
@vgpopov vgpopov changed the title Skip two tests that fail the k8s monorepo job Skip two k8s-failing tests and fix the template dedup test Nov 13, 2026
The V3 test failed the same way as the V2 test: '172080|08b0...' against '172080|' (platforma run 43422001305). The empty changeset marks the PR as test-only for check-changesets.
…-run

# Conflicts:
#	lib/node/pl-middle-layer/src/mutator/template/template_cache.test.ts
#	tests/drivers-ml-blocks-integration/src/template-cache-v3.test.ts
@vgpopov vgpopov changed the title Skip two k8s-failing tests and fix the template dedup test Skip two k8s-failing tests Nov 16, 2026
Comment on lines +283 to +284
// On k8s the library is in S3, and the effect map gets ready with no import error.
if (process.env.PL_TEST_K8S === "1") skip("on k8s the import error does not get to the effect");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it? Looks strange that we provide OK for any item in store, even when it is absent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants